drivers/base/memory: Fix comments for phys_index_show()
authorGavin Shan <gshan@redhat.com>
Fri, 20 Jan 2023 05:57:26 +0000 (13:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Jan 2023 13:15:00 +0000 (14:15 +0100)
According to 'admin-guide/mm/memory-hotplug.rst', the memory block ID,
instead of the section index, is shown by '/sys/devices/system/memory/
memoryX/phys_index'.

Fix the comments to match with 'admin-guide/mm/memory-hotplug.rst'.
Besides, use the existing helper memory_block_id() to convert the section
index to the memory block index.

No functional change intended.

Signed-off-by: Gavin Shan <gshan@redhat.com>
Link: https://lore.kernel.org/r/20230120055727.355483-2-gshan@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/memory.c

index fe98fb8d94e51c7749f3fa75f0f014ca804adfee..b456ac21361058d1c007bdfdca5b2eed996e57aa 100644 (file)
@@ -115,18 +115,13 @@ unsigned long __weak memory_block_size_bytes(void)
 }
 EXPORT_SYMBOL_GPL(memory_block_size_bytes);
 
-/*
- * Show the first physical section index (number) of this memory block.
- */
+/* Show the memory block ID, relative to the memory block size */
 static ssize_t phys_index_show(struct device *dev,
                               struct device_attribute *attr, char *buf)
 {
        struct memory_block *mem = to_memory_block(dev);
-       unsigned long phys_index;
-
-       phys_index = mem->start_section_nr / sections_per_block;
 
-       return sysfs_emit(buf, "%08lx\n", phys_index);
+       return sysfs_emit(buf, "%08lx\n", memory_block_id(mem->start_section_nr));
 }
 
 /*