nvmet-rdma: replace ida_simple[get|remove] with the simler ida_[alloc|free]
authorSagi Grimberg <sagi@grimberg.me>
Mon, 14 Feb 2022 09:07:31 +0000 (11:07 +0200)
committerChristoph Hellwig <hch@lst.de>
Mon, 28 Feb 2022 11:45:05 +0000 (13:45 +0200)
ida_simple_[get|remove] are wrappers anyways.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/rdma.c

index 1deb4043e2425dc12f1fadc96bf1049722351d69..00656754e33142e2bda28bf9171a700b0520ea07 100644 (file)
@@ -1356,7 +1356,7 @@ static void nvmet_rdma_free_queue(struct nvmet_rdma_queue *queue)
                                !queue->host_qid);
        }
        nvmet_rdma_free_rsps(queue);
-       ida_simple_remove(&nvmet_rdma_queue_ida, queue->idx);
+       ida_free(&nvmet_rdma_queue_ida, queue->idx);
        kfree(queue);
 }
 
@@ -1459,7 +1459,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
        spin_lock_init(&queue->rsps_lock);
        INIT_LIST_HEAD(&queue->queue_list);
 
-       queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL);
+       queue->idx = ida_alloc(&nvmet_rdma_queue_ida, GFP_KERNEL);
        if (queue->idx < 0) {
                ret = NVME_RDMA_CM_NO_RSC;
                goto out_destroy_sq;
@@ -1510,7 +1510,7 @@ out_free_cmds:
 out_free_responses:
        nvmet_rdma_free_rsps(queue);
 out_ida_remove:
-       ida_simple_remove(&nvmet_rdma_queue_ida, queue->idx);
+       ida_free(&nvmet_rdma_queue_ida, queue->idx);
 out_destroy_sq:
        nvmet_sq_destroy(&queue->nvme_sq);
 out_free_queue: