net/mlx5: Bridge, fix ageing of peer FDB entries
authorVlad Buslov <vladbu@nvidia.com>
Thu, 26 Jan 2023 13:47:12 +0000 (14:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 18:18:00 +0000 (19:18 +0100)
[ Upstream commit da0c52426cd23f8728eff72c2b2d2a3eb6b451f5 ]

SWITCHDEV_FDB_ADD_TO_BRIDGE event handler that updates FDB entry 'lastuse'
field is only executed for eswitch that owns the entry. However, if peer
entry processed packets at least once it will have hardware counter 'used'
value greater than entry 'lastuse' from that point on, which will cause FDB
entry not being aged out.

Process the event on all eswitch instances.

Fixes: ff9b7521468b ("net/mlx5: Bridge, support LAG")
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c
drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c

index 8e7177d4539e309f3174e3ce5b196a05b6125976..291bd59639044e94254ebfb3c953b570a17b9cc8 100644 (file)
@@ -432,10 +432,6 @@ static int mlx5_esw_bridge_switchdev_event(struct notifier_block *nb,
 
        switch (event) {
        case SWITCHDEV_FDB_ADD_TO_BRIDGE:
-               /* only handle the event on native eswtich of representor */
-               if (!mlx5_esw_bridge_is_local(dev, rep, esw))
-                       break;
-
                fdb_info = container_of(info,
                                        struct switchdev_notifier_fdb_info,
                                        info);
index 317d76b97c42a46c50c5bb4d955ca8029a8cd363..aec0f67cef005e0d2daa5afc3f5275c83742ab7a 100644 (file)
@@ -1270,7 +1270,7 @@ void mlx5_esw_bridge_fdb_update_used(struct net_device *dev, u16 vport_num, u16
        struct mlx5_esw_bridge *bridge;
 
        port = mlx5_esw_bridge_port_lookup(vport_num, esw_owner_vhca_id, br_offloads);
-       if (!port || port->flags & MLX5_ESW_BRIDGE_PORT_FLAG_PEER)
+       if (!port)
                return;
 
        bridge = port->bridge;