ath10k: enable firmware log by default for sdio
authorWen Gong <wgong@codeaurora.org>
Fri, 8 Nov 2019 09:19:14 +0000 (17:19 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 29 Nov 2019 07:40:53 +0000 (09:40 +0200)
On SDIO chips the firmware log does not impact performance. To make it
easier to debug firmware problems keep it enabled on the firmware.

Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.

Signed-off-by: Wen Gong <wgong@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/core.c

index 0d345852c04a9f29f937ee48d25aa7fc365a5603..6da377317d1fae15c67ff9a9c9e9ea618d1a5083 100644 (file)
@@ -715,18 +715,6 @@ static int ath10k_init_sdio(struct ath10k *ar, enum ath10k_firmware_mode mode)
        if (ret)
                return ret;
 
-       /* Explicitly set fwlog prints to zero as target may turn it on
-        * based on scratch registers.
-        */
-       ret = ath10k_bmi_read32(ar, hi_option_flag, &param);
-       if (ret)
-               return ret;
-
-       param |= HI_OPTION_DISABLE_DBGLOG;
-       ret = ath10k_bmi_write32(ar, hi_option_flag, param);
-       if (ret)
-               return ret;
-
        return 0;
 }