drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

Fix an incorrect NULL check reported by kbot in the MSM DP driver

smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect()
error: we previously assumed 'hpd_priv->dp_cb' could be null
(see line 37)

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/1614971839-2686-2-git-send-email-abhinavk@codeaurora.org
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/dp/dp_hpd.c b/drivers/gpu/drm/msm/dp/dp_hpd.c
index 5b8fe32022b5fefe3f3eb80e4c771ff8a0f5cc27..e1c90fa47411f79e7ca15cd641628094b3f939e8 100644 (file)
--- a/drivers/gpu/drm/msm/dp/dp_hpd.c
+++ b/drivers/gpu/drm/msm/dp/dp_hpd.c
@@ -34,8 +34,8 @@ int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)
 
        dp_usbpd->hpd_high = hpd;
 
-       if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
-                               && !hpd_priv->dp_cb->disconnect) {
+       if (!hpd_priv->dp_cb || !hpd_priv->dp_cb->configure
+                               || !hpd_priv->dp_cb->disconnect) {
                pr_err("hpd dp_cb not initialized\n");
                return -EINVAL;
        }