remoteproc: Harden rproc_handle_vdev() against integer overflow

The struct_size() macro protects against integer overflows but adding
"+ rsc->config_len" introduces the risk of integer overflows again.
Use size_add() to be safe.

Fixes: c87846571587 ("remoteproc: use struct_size() helper")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Link: https://lore.kernel.org/r/YyMyoPoGOJUcEpZT@kili
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 6e8849f0df18a5eb801834caf7d6d83aad27a3b5..f5ba3b305aaffeb110f6bc2ed3b156fad75a37ff 100644 (file)
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -520,12 +520,13 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr,
        struct fw_rsc_vdev *rsc = ptr;
        struct device *dev = &rproc->dev;
        struct rproc_vdev *rvdev;
+       size_t rsc_size;
        int i, ret;
        char name[16];
 
        /* make sure resource isn't truncated */
-       if (struct_size(rsc, vring, rsc->num_of_vrings) + rsc->config_len >
-                       avail) {
+       rsc_size = struct_size(rsc, vring, rsc->num_of_vrings);
+       if (size_add(rsc_size, rsc->config_len) > avail) {
                dev_err(dev, "vdev rsc is truncated\n");
                return -EINVAL;
        }