net: ll_temac: delete unnecessary else branch
authorhuangjunxian <huangjunxian6@hisilicon.com>
Sat, 17 Sep 2022 10:38:40 +0000 (18:38 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Sep 2022 01:25:19 +0000 (18:25 -0700)
Cleaning some static warnings of unnecessary else branch.

Signed-off-by: huangjunxian <huangjunxian6@hisilicon.com>
Signed-off-by: Haoyue Xu <xuhaoyue1@hisilicon.com>
Reviewed-by: Harini Katakam <harini.katakam@amd.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/xilinx/ll_temac_main.c

index 586017792181483899319ccc151ed2599f2e3c79..eadd275313a1eec8d94fbd94eb342ed131adf749 100644 (file)
@@ -117,8 +117,8 @@ int temac_indirect_busywait(struct temac_local *lp)
        spin_until_cond(hard_acs_rdy_or_timeout(lp, timeout));
        if (WARN_ON(!hard_acs_rdy(lp)))
                return -ETIMEDOUT;
-       else
-               return 0;
+
+       return 0;
 }
 
 /*
@@ -307,11 +307,9 @@ static void temac_dma_bd_release(struct net_device *ndev)
        for (i = 0; i < lp->rx_bd_num; i++) {
                if (!lp->rx_skb[i])
                        break;
-               else {
-                       dma_unmap_single(ndev->dev.parent, lp->rx_bd_v[i].phys,
-                                        XTE_MAX_JUMBO_FRAME_SIZE, DMA_FROM_DEVICE);
-                       dev_kfree_skb(lp->rx_skb[i]);
-               }
+               dma_unmap_single(ndev->dev.parent, lp->rx_bd_v[i].phys,
+                                XTE_MAX_JUMBO_FRAME_SIZE, DMA_FROM_DEVICE);
+               dev_kfree_skb(lp->rx_skb[i]);
        }
        if (lp->rx_bd_v)
                dma_free_coherent(ndev->dev.parent,