memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings()

[ Upstream commit 48af14fb0eaa63d9aa68f59fb0b205ec55a95636 ]

We should add the of_node_put() when breaking out of
for_each_child_of_node() as it will automatically increase
and decrease the refcount.

Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
index d0a80aefdea8e6176ff1e5797baf30e37c93851d..1791614f324b7dca6668f89a1d4e751afb9fee82 100644 (file)
--- a/drivers/memory/of_memory.c
+++ b/drivers/memory/of_memory.c
@@ -283,6 +283,7 @@ const struct lpddr3_timings
                if (of_device_is_compatible(np_tim, tim_compat)) {
                        if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {
                                devm_kfree(dev, timings);
+                               of_node_put(np_tim);
                                goto default_timings;
                        }
                        i++;