staging: mt7621-pci: remove unnecessary check of device_type == pci
authorRob Herring <robh@kernel.org>
Wed, 29 Aug 2018 18:34:03 +0000 (13:34 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 10 Sep 2018 08:38:17 +0000 (10:38 +0200)
PCI host drivers have already matched on compatible strings, so checking
device_type is redundant. Also, device_type is considered deprecated for
FDT though we've still been requiring it for PCI hosts as it is useful
for finding PCI buses.

Cc: devel@driverdev.osuosl.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-pci/pci-mt7621.c

index df2d522abac453e38f0d3150c3ef0a02d1dd7b06..ba1f117a47ced37d95902ad3fa811d188f5ca8a6 100644 (file)
@@ -387,15 +387,8 @@ static int mt7621_pcie_parse_dt(struct mt7621_pcie *pcie)
        struct device *dev = pcie->dev;
        struct device_node *node = dev->of_node;
        struct resource regs;
-       const char *type;
        int err;
 
-       type = of_get_property(node, "device_type", NULL);
-       if (!type || strcmp(type, "pci") != 0) {
-               dev_err(dev, "invalid \"device_type\" %s\n", type);
-               return -EINVAL;
-       }
-
        err = of_address_to_resource(node, 0, &regs);
        if (err) {
                dev_err(dev, "missing \"reg\" property\n");