drm/tegra: hdmi: Unwind tegra_hdmi_init() errors

Add missing error unwinding to tegra_hdmi_init(), for consistency.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index e5d2a40260288742fd956931fd48416f46bdd1b5..704271511d2bc82ffd47e09da3f658d9863cd6bb 100644 (file)
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1453,22 +1453,31 @@ static int tegra_hdmi_init(struct host1x_client *client)
        if (err < 0) {
                dev_err(client->dev, "failed to enable HDMI regulator: %d\n",
                        err);
-               return err;
+               goto output_exit;
        }
 
        err = regulator_enable(hdmi->pll);
        if (err < 0) {
                dev_err(hdmi->dev, "failed to enable PLL regulator: %d\n", err);
-               return err;
+               goto disable_hdmi;
        }
 
        err = regulator_enable(hdmi->vdd);
        if (err < 0) {
                dev_err(hdmi->dev, "failed to enable VDD regulator: %d\n", err);
-               return err;
+               goto disable_pll;
        }
 
        return 0;
+
+disable_pll:
+       regulator_disable(hdmi->pll);
+disable_hdmi:
+       regulator_disable(hdmi->hdmi);
+output_exit:
+       tegra_output_exit(&hdmi->output);
+
+       return err;
 }
 
 static int tegra_hdmi_exit(struct host1x_client *client)