projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b8a555d
)
eventfs: Fix failure path in eventfs_create_events_dir()
author
Steven Rostedt (Google)
<rostedt@goodmis.org>
Fri, 20 Oct 2023 00:41:32 +0000
(20:41 -0400)
committer
Steven Rostedt (Google)
<rostedt@goodmis.org>
Fri, 20 Oct 2023 14:04:01 +0000
(10:04 -0400)
The failure path of allocating ei goes to a path that dereferences ei.
Add another label that skips over the ei dereferences to do the rest of
the clean up.
Link:
https://lore.kernel.org/all/70e7bace-561c-95f-1117-706c2c220bc@inria.fr/
Link:
https://lore.kernel.org/linux-trace-kernel/20231019204132.6662fef0@gandalf.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
fs/tracefs/event_inode.c
patch
|
blob
|
history
diff --git
a/fs/tracefs/event_inode.c
b/fs/tracefs/event_inode.c
index 9f19b660895488c459a4e4b28524d714cb26e4f3..1885f1f1f339d925394fd2ba7da26a01d9867bb8 100644
(file)
--- a/
fs/tracefs/event_inode.c
+++ b/
fs/tracefs/event_inode.c
@@
-735,7
+735,7
@@
struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry
ei = kzalloc(sizeof(*ei), GFP_KERNEL);
if (!ei)
- goto fail;
+ goto fail
_ei
;
inode = tracefs_get_inode(dentry->d_sb);
if (unlikely(!inode))
@@
-781,6
+781,7
@@
struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry
fail:
kfree(ei->d_children);
kfree(ei);
+ fail_ei:
tracefs_failed_creating(dentry);
return ERR_PTR(-ENOMEM);
}