leds: pwm: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:50:11 +0000 (16:50 +0200)
committerPavel Machek <pavel@ucw.cz>
Wed, 9 Sep 2020 09:20:09 +0000 (11:20 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-pwm.c

index ef7b91bd2064f40401142c3f7bb252c929631c00..e35a97c1d828514b9631e5079c22a50f402501ee 100644 (file)
@@ -78,13 +78,10 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
                led_data->pwm = devm_fwnode_pwm_get(dev, fwnode, NULL);
        else
                led_data->pwm = devm_pwm_get(dev, led->name);
-       if (IS_ERR(led_data->pwm)) {
-               ret = PTR_ERR(led_data->pwm);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "unable to request PWM for %s: %d\n",
-                               led->name, ret);
-               return ret;
-       }
+       if (IS_ERR(led_data->pwm))
+               return dev_err_probe(dev, PTR_ERR(led_data->pwm),
+                                    "unable to request PWM for %s\n",
+                                    led->name);
 
        led_data->cdev.brightness_set_blocking = led_pwm_set;