video: fbdev: omapfb: panel-sharp-ls037v7dw01: Make use of the helper function dev_er...
authorCai Huoqing <caihuoqing@baidu.com>
Fri, 17 Sep 2021 04:24:12 +0000 (12:24 +0800)
committerHelge Deller <deller@gmx.de>
Sat, 29 Jan 2022 22:22:01 +0000 (23:22 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c

index 602324c5c9f9c6cd6d601c3fef87e6d957b1a757..f1072c319de8ab8d11f7c7a3c0b80db1dab34d22 100644 (file)
@@ -211,10 +211,9 @@ static int sharp_ls_probe_of(struct platform_device *pdev)
        int r;
 
        ddata->vcc = devm_regulator_get(&pdev->dev, "envdd");
-       if (IS_ERR(ddata->vcc)) {
-               dev_err(&pdev->dev, "failed to get regulator\n");
-               return PTR_ERR(ddata->vcc);
-       }
+       if (IS_ERR(ddata->vcc))
+               return dev_err_probe(&pdev->dev, PTR_ERR(ddata->vcc),
+                                    "failed to get regulator\n");
 
        /* lcd INI */
        r = sharp_ls_get_gpio_of(&pdev->dev, 0, 0, "enable", &ddata->ini_gpio);