nubus: Drop noop match function
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 13 Mar 2023 18:08:48 +0000 (19:08 +0100)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 20 Mar 2023 14:39:14 +0000 (15:39 +0100)
nubus_bus_match() returned 1 unconditionally. This is equivalent to
no match function at all. (See driver_match_device() which does:

return drv->bus->match ? drv->bus->match(dev, drv) : 1;

.)

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Finn Thain <fthain@linux-m68k.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20230313180848.2770504-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
drivers/nubus/bus.c

index 17fad660032c83ae4b22fcce98744e4d3963fec0..72921e4f35f6e6b5414fd98b64ef851879464356 100644 (file)
 #define to_nubus_board(d)       container_of(d, struct nubus_board, dev)
 #define to_nubus_driver(d)      container_of(d, struct nubus_driver, driver)
 
-static int nubus_bus_match(struct device *dev, struct device_driver *driver)
-{
-       return 1;
-}
-
 static int nubus_device_probe(struct device *dev)
 {
        struct nubus_driver *ndrv = to_nubus_driver(dev->driver);
@@ -39,7 +34,6 @@ static void nubus_device_remove(struct device *dev)
 
 struct bus_type nubus_bus_type = {
        .name           = "nubus",
-       .match          = nubus_bus_match,
        .probe          = nubus_device_probe,
        .remove         = nubus_device_remove,
 };