extcon: Remove redundant null checking for class
authorBumwoo Lee <bw365.lee@samsung.com>
Thu, 2 Mar 2023 09:01:40 +0000 (18:01 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 29 May 2023 14:31:24 +0000 (23:31 +0900)
create_extcon_class() is already Null checking.

Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon.c

index d43ba8e7260dd03ad893612669d3fde1104fc830..2fa033711a554d7b7ee0792e91b286d1ee7f01fd 100644 (file)
@@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
 
 static int create_extcon_class(void)
 {
-       if (!extcon_class) {
-               extcon_class = class_create("extcon");
-               if (IS_ERR(extcon_class))
-                       return PTR_ERR(extcon_class);
-               extcon_class->dev_groups = extcon_groups;
-       }
+       if (extcon_class)
+               return 0;
+
+       extcon_class = class_create("extcon");
+       if (IS_ERR(extcon_class))
+               return PTR_ERR(extcon_class);
+       extcon_class->dev_groups = extcon_groups;
 
        return 0;
 }
@@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
        int ret, index = 0;
        static atomic_t edev_no = ATOMIC_INIT(-1);
 
-       if (!extcon_class) {
-               ret = create_extcon_class();
-               if (ret < 0)
-                       return ret;
-       }
+       ret = create_extcon_class();
+       if (ret < 0)
+               return ret;
 
        if (!edev || !edev->supported_cable)
                return -EINVAL;