ASoC: wcd934x: remove useless return
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 18 Feb 2021 22:29:15 +0000 (16:29 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:01:57 +0000 (13:01 +0000)
cppcheck warning:

sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition and
return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/codecs/wcd934x.c:1568:6: note: If condition 'ret' is true,
the function will return/exit
 if (ret)
     ^
sound/soc/codecs/wcd934x.c:1571:9: note: Returning identical
expression 'ret'
 return ret;
        ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210218222916.89809-10-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd934x.c

index d18ae5e3ee809ddf31fd957d42d57b9f0f5c124f..2c4818dc2e6d44947dfc437a186fd8cb44951dc1 100644 (file)
@@ -1565,8 +1565,6 @@ static int wcd934x_set_interpolator_rate(struct snd_soc_dai *dai,
                return ret;
        ret = wcd934x_set_mix_interpolator_rate(dai, (u8)rate_val,
                                                sample_rate);
-       if (ret)
-               return ret;
 
        return ret;
 }