i2c: robotfuzz-osif: remove pointless local variable
authorPeter Rosin <peda@axentia.se>
Wed, 9 May 2018 19:46:57 +0000 (21:46 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 24 May 2018 20:12:24 +0000 (22:12 +0200)
Just use the value directly instead of assigning it to a
variable first. And then drop the unused variable.

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-robotfuzz-osif.c

index 9c0f52b7ff7ec4a04660c4fe2b00d471463531a9..51d93b4b00f2105c2c721b1db1c6855cdf546982 100644 (file)
@@ -63,26 +63,23 @@ static int osif_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs,
        struct osif_priv *priv = adapter->algo_data;
        struct i2c_msg *pmsg;
        int ret = 0;
-       int i, cmd;
+       int i;
 
        for (i = 0; ret >= 0 && i < num; i++) {
                pmsg = &msgs[i];
 
                if (pmsg->flags & I2C_M_RD) {
-                       cmd = OSIFI2C_READ;
-
-                       ret = osif_usb_read(adapter, cmd, pmsg->flags,
-                                           pmsg->addr, pmsg->buf,
-                                           pmsg->len);
+                       ret = osif_usb_read(adapter, OSIFI2C_READ,
+                                           pmsg->flags, pmsg->addr,
+                                           pmsg->buf, pmsg->len);
                        if (ret != pmsg->len) {
                                dev_err(&adapter->dev, "failure reading data\n");
                                return -EREMOTEIO;
                        }
                } else {
-                       cmd = OSIFI2C_WRITE;
-
-                       ret = osif_usb_write(adapter, cmd, pmsg->flags,
-                                            pmsg->addr, pmsg->buf, pmsg->len);
+                       ret = osif_usb_write(adapter, OSIFI2C_WRITE,
+                                            pmsg->flags, pmsg->addr,
+                                            pmsg->buf, pmsg->len);
                        if (ret != pmsg->len) {
                                dev_err(&adapter->dev, "failure writing data\n");
                                return -EREMOTEIO;