habanalabs: remove prints on successful device initialization
authorOded Gabbay <oded.gabbay@gmail.com>
Sat, 16 Nov 2019 10:24:19 +0000 (12:24 +0200)
committerOded Gabbay <oded.gabbay@gmail.com>
Thu, 21 Nov 2019 09:35:46 +0000 (11:35 +0200)
Successful device initialization is mentioned in kernel log with the
message "Successfully added device to habanalabs driver". There is no point
of spamming the log with additional messages about successful queue
testing, which are implied by the above mentioned message.

Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Reviewed-by: Omer Shpigelman <oshpigelman@habana.ai>
drivers/misc/habanalabs/firmware_if.c
drivers/misc/habanalabs/goya/goya.c

index ea2ca67fbfbfaf9fc01f8160b539a57149bd8e0f..f5bd03171dac7d0e64db3478aa64262f2b36a26d 100644 (file)
@@ -143,10 +143,7 @@ int hl_fw_test_cpu_queue(struct hl_device *hdev)
                        sizeof(test_pkt), HL_DEVICE_TIMEOUT_USEC, &result);
 
        if (!rc) {
-               if (result == ARMCP_PACKET_FENCE_VAL)
-                       dev_info(hdev->dev,
-                               "queue test on CPU queue succeeded\n");
-               else
+               if (result != ARMCP_PACKET_FENCE_VAL)
                        dev_err(hdev->dev,
                                "CPU queue test failed (0x%08lX)\n", result);
        } else {
index 2935e84fe7d8bafe27d41fb37852f2e98f4db1e2..70bdaeffb6ce7fb5059bbcacadc1c7fca0ddbcc3 100644 (file)
@@ -3006,9 +3006,6 @@ int goya_test_queue(struct hl_device *hdev, u32 hw_queue_id)
                        "H/W queue %d test failed (scratch(0x%08llX) == 0x%08X)\n",
                        hw_queue_id, (unsigned long long) fence_dma_addr, tmp);
                rc = -EIO;
-       } else {
-               dev_info(hdev->dev, "queue test on H/W queue %d succeeded\n",
-                       hw_queue_id);
        }
 
 free_pkt: