staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless copy
authorLee Jones <lee.jones@linaro.org>
Wed, 14 Apr 2021 18:11:02 +0000 (19:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 10 May 2021 09:19:25 +0000 (11:19 +0200)
Fixes the following W=1 kernel build warning(s):

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c: In function ‘rtw_ies_remove_ie’:
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c:259:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210414181129.1628598-31-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_ieee80211.c

index ae057eefeeb3603c5d8cb663452cf20371d818ab..d8513acf4911caf33faa96253794a4362955c90c 100644 (file)
@@ -239,12 +239,10 @@ int rtw_ies_remove_ie(u8 *ies, uint *ies_len, uint offset, u8 eid, u8 *oui, u8 o
        while (1) {
                target_ie = rtw_get_ie_ex(start, search_len, eid, oui, oui_len, NULL, &target_ielen);
                if (target_ie && target_ielen) {
-                       u8 buf[MAX_IE_SZ] = {0};
                        u8 *remain_ies = target_ie + target_ielen;
                        uint remain_len = search_len - (remain_ies - start);
 
-                       memcpy(buf, remain_ies, remain_len);
-                       memcpy(target_ie, buf, remain_len);
+                       memcpy(target_ie, remain_ies, remain_len);
                        *ies_len = *ies_len - target_ielen;
                        ret = _SUCCESS;