openpic_kvm: drop address_space_to_flatview call
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 5 Mar 2018 08:18:26 +0000 (09:18 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 6 Mar 2018 13:01:27 +0000 (14:01 +0100)
The MemoryListener is registered on address_space_memory, there is
not much to assert.  This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.

This confines address_space_to_flatview to exec.c and memory.c.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/intc/openpic_kvm.c

index f1a59e5a8519d9a56a1b5025fac242c2ba961e88..928bc04a4eb85b3d0c2fc4fb720da2bcffcb3d3a 100644 (file)
@@ -125,10 +125,6 @@ static void kvm_openpic_region_add(MemoryListener *listener,
     uint64_t reg_base;
     int ret;
 
-    if (section->fv != address_space_to_flatview(&address_space_memory)) {
-        abort();
-    }
-
     /* Ignore events on regions that are not us */
     if (section->mr != &opp->mem) {
         return;