wifi: ath12k: Remove unused scan_flags from struct ath12k_wmi_scan_req_arg
authorNicolas Escande <nico.escande@gmail.com>
Sun, 11 Feb 2024 14:55:48 +0000 (15:55 +0100)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 14 Feb 2024 08:16:56 +0000 (10:16 +0200)
As we did for ath11k lets remove the unused scan_flags from struct
ath12k_wmi_scan_req_arg. This will prevent us from using out of sync values
between WMI_SCAN_XXX & scan_f_xxx bitfield.
While at it remove the underlying wrapping struct/union construct as it serves
no purpose anymore.

Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240211145548.1939610-3-nico.escande@gmail.com
drivers/net/wireless/ath/ath12k/wmi.h

index 4bd1d0f270a1096022e1be63820fd7b7dd8b6302..892f21f95ee5915f9be36fa8b82ff992f24c8d72 100644 (file)
@@ -3311,36 +3311,31 @@ struct ath12k_wmi_scan_req_arg {
        u32 idle_time;
        u32 max_scan_time;
        u32 probe_delay;
-       union {
-               struct {
-                       u32 scan_f_passive:1,
-                           scan_f_bcast_probe:1,
-                           scan_f_cck_rates:1,
-                           scan_f_ofdm_rates:1,
-                           scan_f_chan_stat_evnt:1,
-                           scan_f_filter_prb_req:1,
-                           scan_f_bypass_dfs_chn:1,
-                           scan_f_continue_on_err:1,
-                           scan_f_offchan_mgmt_tx:1,
-                           scan_f_offchan_data_tx:1,
-                           scan_f_promisc_mode:1,
-                           scan_f_capture_phy_err:1,
-                           scan_f_strict_passive_pch:1,
-                           scan_f_half_rate:1,
-                           scan_f_quarter_rate:1,
-                           scan_f_force_active_dfs_chn:1,
-                           scan_f_add_tpc_ie_in_probe:1,
-                           scan_f_add_ds_ie_in_probe:1,
-                           scan_f_add_spoofed_mac_in_probe:1,
-                           scan_f_add_rand_seq_in_probe:1,
-                           scan_f_en_ie_whitelist_in_probe:1,
-                           scan_f_forced:1,
-                           scan_f_2ghz:1,
-                           scan_f_5ghz:1,
-                           scan_f_80mhz:1;
-               };
-               u32 scan_flags;
-       };
+       u32 scan_f_passive:1,
+           scan_f_bcast_probe:1,
+           scan_f_cck_rates:1,
+           scan_f_ofdm_rates:1,
+           scan_f_chan_stat_evnt:1,
+           scan_f_filter_prb_req:1,
+           scan_f_bypass_dfs_chn:1,
+           scan_f_continue_on_err:1,
+           scan_f_offchan_mgmt_tx:1,
+           scan_f_offchan_data_tx:1,
+           scan_f_promisc_mode:1,
+           scan_f_capture_phy_err:1,
+           scan_f_strict_passive_pch:1,
+           scan_f_half_rate:1,
+           scan_f_quarter_rate:1,
+           scan_f_force_active_dfs_chn:1,
+           scan_f_add_tpc_ie_in_probe:1,
+           scan_f_add_ds_ie_in_probe:1,
+           scan_f_add_spoofed_mac_in_probe:1,
+           scan_f_add_rand_seq_in_probe:1,
+           scan_f_en_ie_whitelist_in_probe:1,
+           scan_f_forced:1,
+           scan_f_2ghz:1,
+           scan_f_5ghz:1,
+           scan_f_80mhz:1;
        enum scan_dwelltime_adaptive_mode adaptive_dwell_time_mode;
        u32 burst_duration;
        u32 num_chan;