don't use 'Yoda conditions'
authorGonglei <arei.gonglei@huawei.com>
Mon, 11 Aug 2014 13:00:55 +0000 (21:00 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 15 Aug 2014 14:54:07 +0000 (18:54 +0400)
imitate nearby code about using '!value' or 'value == NULL'

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
qdev-monitor.c
qemu-char.c
util/qemu-sockets.c

index f87f3d89cd5fddc91f47128d9e3478df17a447d0..81a4e9b27fbf458f0c11f24070b6899c876c14c2 100644 (file)
@@ -694,7 +694,7 @@ void qmp_device_del(const char *id, Error **errp)
     DeviceState *dev;
 
     dev = qdev_find_recursive(sysbus_get_default(), id);
-    if (NULL == dev) {
+    if (!dev) {
         error_set(errp, QERR_DEVICE_NOT_FOUND, id);
         return;
     }
index 6964a2d9fda9c160b6c78f46c112a804423beba7..3dcc39adf8ecd376adab5841170a452a5455b7b6 100644 (file)
@@ -4121,7 +4121,7 @@ void qmp_chardev_remove(const char *id, Error **errp)
     CharDriverState *chr;
 
     chr = qemu_chr_find(id);
-    if (NULL == chr) {
+    if (chr == NULL) {
         error_setg(errp, "Chardev '%s' not found", id);
         return;
     }
index 74cf0786e5711d031bdcb05888328bed9adfc50e..5d38395f2d5b4e7fb2da3dcd02402edce9d2c84f 100644 (file)
@@ -732,7 +732,7 @@ int unix_connect_opts(QemuOpts *opts, Error **errp,
     ConnectState *connect_state = NULL;
     int sock, rc;
 
-    if (NULL == path) {
+    if (path == NULL) {
         error_setg(errp, "unix connect: no path specified");
         return -1;
     }