staging: r8188eu: remove return value from on_action_public_default
authorMartin Kaiser <martin@kaiser.cx>
Sun, 30 Oct 2022 17:33:24 +0000 (18:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 31 Oct 2022 08:09:05 +0000 (09:09 +0100)
The only caller of on_action_public_default does not check the return
value. We can make it a void function.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20221030173326.1588647-12-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_mlme_ext.c

index b395457a6a60a0a1c02ed81366fc9cb8da2ccb85..f5923792f0675e221aacc8b36530a2b30725993b 100644 (file)
@@ -3788,22 +3788,15 @@ static void on_action_public_vendor(struct recv_frame *precv_frame)
                on_action_public_p2p(precv_frame);
 }
 
-static unsigned int on_action_public_default(struct recv_frame *precv_frame)
+static void on_action_public_default(struct recv_frame *precv_frame)
 {
-       unsigned int ret = _FAIL;
        u8 *pframe = precv_frame->rx_data;
        u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr);
        u8 token;
 
        token = frame_body[2];
 
-       if (rtw_action_public_decache(precv_frame, token) == _FAIL)
-               goto exit;
-
-       ret = _SUCCESS;
-
-exit:
-       return ret;
+       rtw_action_public_decache(precv_frame, token);
 }
 
 static void on_action_public(struct adapter *padapter, struct recv_frame *precv_frame)