drm/amdkfd: call amdgpu_amdkfd_get_unique_id directly
authorFelix Kuehling <Felix.Kuehling@amd.com>
Mon, 24 Aug 2020 13:55:16 +0000 (09:55 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 26 Aug 2020 20:40:18 +0000 (16:40 -0400)
No need to use a function pointer because the implementation is not
ASIC-specific. This fixes missing support due to a missing function
pointer on Arcturus.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c
drivers/gpu/drm/amd/amdkfd/kfd_device.c
drivers/gpu/drm/amd/include/kgd_kfd_interface.h

index b0dcc800251ee861af9ba1480f3af9430be5c3dd..e9aee50a079082c09f743438b8f732695cdd8881 100644 (file)
@@ -777,5 +777,4 @@ const struct kfd2kgd_calls gfx_v10_kfd2kgd = {
                        get_atc_vmid_pasid_mapping_info,
        .set_vm_context_page_table_base = set_vm_context_page_table_base,
        .get_hive_id = amdgpu_amdkfd_get_hive_id,
-       .get_unique_id = amdgpu_amdkfd_get_unique_id,
 };
index d08839d9491f496e273a926d6d2653c0342a57c9..1769cd4b6cef4aa1ffd4c14ed4910f94fa663230 100644 (file)
@@ -727,5 +727,4 @@ const struct kfd2kgd_calls gfx_v9_kfd2kgd = {
                        kgd_gfx_v9_get_atc_vmid_pasid_mapping_info,
        .set_vm_context_page_table_base = kgd_gfx_v9_set_vm_context_page_table_base,
        .get_hive_id = amdgpu_amdkfd_get_hive_id,
-       .get_unique_id = amdgpu_amdkfd_get_unique_id,
 };
index b15b620e731b7f8ab14e9da3d13f67748d824781..5ffd0368572244c34175f26ea2f53236edb7a032 100644 (file)
@@ -715,8 +715,7 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd,
        if (kfd->kfd2kgd->get_hive_id)
                kfd->hive_id = kfd->kfd2kgd->get_hive_id(kfd->kgd);
 
-       if (kfd->kfd2kgd->get_unique_id)
-               kfd->unique_id = kfd->kfd2kgd->get_unique_id(kfd->kgd);
+       kfd->unique_id = amdgpu_amdkfd_get_unique_id(kfd->kgd);
 
        if (kfd_interrupt_init(kfd)) {
                dev_err(kfd_device, "Error initializing interrupts\n");
index a3c238c39ef57233d76465419da5876ba6e886db..017f97394344728a8eda9c0fe14ecd60ac2e3658 100644 (file)
@@ -214,8 +214,6 @@ struct tile_config {
  *
  * @get_hive_id: Returns hive id of current  device,  0 if xgmi is not enabled
  *
- * @get_unique_id: Returns uuid id of current  device
- * 
  * This structure contains function pointers to services that the kgd driver
  * provides to amdkfd driver.
  *
@@ -291,8 +289,6 @@ struct kfd2kgd_calls {
                        uint32_t vmid, uint64_t page_table_base);
        uint32_t (*read_vmid_from_vmfault_reg)(struct kgd_dev *kgd);
        uint64_t (*get_hive_id)(struct kgd_dev *kgd);
-       uint64_t (*get_unique_id)(struct kgd_dev *kgd);
-
 };
 
 #endif /* KGD_KFD_INTERFACE_H_INCLUDED */