media: vimc: initialize vim entity pointers to NULL
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Mon, 7 Oct 2019 13:49:59 +0000 (10:49 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 24 Oct 2019 21:59:52 +0000 (18:59 -0300)
since NULL value for vimc entity pointer indicates
that entity creation failed and this is tested, the
pointers should be initialized to NULL.

Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vimc/vimc-core.c

index 2d20a7c103986d437f2f968743b89c44151f2195..65048bd7d80bbb31f0e22dd8d457c502f8ec9816 100644 (file)
@@ -199,9 +199,8 @@ static int vimc_register_devices(struct vimc_device *vimc)
        }
 
        /* allocate ent_devs */
-       vimc->ent_devs = kmalloc_array(vimc->pipe_cfg->num_ents,
-                                      sizeof(*vimc->ent_devs),
-                                      GFP_KERNEL);
+       vimc->ent_devs = kcalloc(vimc->pipe_cfg->num_ents,
+                                sizeof(*vimc->ent_devs), GFP_KERNEL);
        if (!vimc->ent_devs) {
                ret = -ENOMEM;
                goto err_v4l2_unregister;