scsi: target: tcmu: Fix boolreturn.cocci warnings
authorkernel test robot <lkp@intel.com>
Sat, 15 May 2021 23:03:58 +0000 (07:03 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 May 2021 21:14:21 +0000 (17:14 -0400)
drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Link: https://lore.kernel.org/r/20210515230358.GA97544@60d1edce16e0
Fixes: 9814b55cde05 ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found")
CC: Bodo Stroesser <bostroesser@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_user.c

index 9866d7b49ab863c54bb6e20107e0125ba48bd2d6..3bbe0a7a546597be10404aa29d3d4af97ae6b175 100644 (file)
@@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(struct tcmu_dev *udev)
 
        if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) {
                pr_err("ring broken, not handling completions\n");
-               return 0;
+               return false;
        }
 
        mb = udev->mb_addr;