drm/amdgpu: Fix printk_ratelimit() with DRM_ERROR_RATELIMITED in 'amdgpu_cs_ioctl'
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Thu, 27 Jul 2023 02:32:46 +0000 (08:02 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 30 Aug 2023 19:51:17 +0000 (15:51 -0400)
Replaced printk_ratelimit() with its DRM equivalent to avoid flooding of
dmesg logs & hence fixes the following:

WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
+               if (printk_ratelimit())

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

index 49dd9aa8da70883871c9859717f590df32fc34fa..fe78796f040766d378f817959098b7267e386ba7 100644 (file)
@@ -1402,8 +1402,7 @@ int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
 
        r = amdgpu_cs_parser_init(&parser, adev, filp, data);
        if (r) {
-               if (printk_ratelimit())
-                       DRM_ERROR("Failed to initialize parser %d!\n", r);
+               DRM_ERROR_RATELIMITED("Failed to initialize parser %d!\n", r);
                return r;
        }