Migration/colo.c: Add the necessary checks for colo_do_failover
authorZhang Chen <chen.zhang@intel.com>
Fri, 22 Mar 2019 10:13:32 +0000 (18:13 +0800)
committerJuan Quintela <quintela@redhat.com>
Mon, 25 Mar 2019 17:45:38 +0000 (18:45 +0100)
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/colo.c

index dbe2b888077859985866ae5031aa8e708f291da7..d1ae2e6d11b1b6a38190a4bdd4a450d6a9410395 100644 (file)
@@ -197,10 +197,16 @@ void colo_do_failover(MigrationState *s)
         vm_stop_force_state(RUN_STATE_COLO);
     }
 
-    if (get_colo_mode() == COLO_MODE_PRIMARY) {
+    switch (get_colo_mode()) {
+    case COLO_MODE_PRIMARY:
         primary_vm_do_failover();
-    } else {
+        break;
+    case COLO_MODE_SECONDARY:
         secondary_vm_do_failover();
+        break;
+    default:
+        error_report("colo_do_failover failed because the colo mode"
+                     " could not be obtained");
     }
 }