net: phy: marvell10g: fill in possible_interfaces
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 24 Nov 2023 12:28:03 +0000 (12:28 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 28 Nov 2023 02:04:11 +0000 (18:04 -0800)
Fill in the possible_interfaces member according to the selected
mactype mode.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1r6VHv-00DDLZ-OL@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/marvell10g.c

index a880b3375dee53fc4ee6cb953448d304289338d2..ad43e280930c35eaef7454813143c1a2eb8a0fae 100644 (file)
@@ -803,6 +803,22 @@ static const struct mv3310_mactype mv3340_mactypes[] = {
        },
 };
 
+static void mv3310_fill_possible_interfaces(struct phy_device *phydev)
+{
+       struct mv3310_priv *priv = dev_get_drvdata(&phydev->mdio.dev);
+       unsigned long *possible = phydev->possible_interfaces;
+       const struct mv3310_mactype *mactype = priv->mactype;
+
+       if (mactype->interface_10g != PHY_INTERFACE_MODE_NA)
+               __set_bit(priv->mactype->interface_10g, possible);
+
+       if (!mactype->fixed_interface) {
+               __set_bit(PHY_INTERFACE_MODE_5GBASER, possible);
+               __set_bit(PHY_INTERFACE_MODE_2500BASEX, possible);
+               __set_bit(PHY_INTERFACE_MODE_SGMII, possible);
+       }
+}
+
 static int mv3310_config_init(struct phy_device *phydev)
 {
        struct mv3310_priv *priv = dev_get_drvdata(&phydev->mdio.dev);
@@ -845,6 +861,8 @@ static int mv3310_config_init(struct phy_device *phydev)
 
        priv->mactype = &chip->mactypes[mactype];
 
+       mv3310_fill_possible_interfaces(phydev);
+
        /* Enable EDPD mode - saving 600mW */
        err = mv3310_set_edpd(phydev, ETHTOOL_PHY_EDPD_DFLT_TX_MSECS);
        if (err)