imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Thu, 11 Jan 2018 13:25:38 +0000 (13:25 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 11 Jan 2018 13:25:38 +0000 (13:25 +0000)
Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset
0x614, so to avoid getting aborts when accessing those on QEMU, extend
the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space
instead of just 1K.

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Cc: yurovsky@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/net/imx_fec.c
include/hw/arm/fsl-imx25.h
include/hw/net/imx_fec.h

index c1cf7f9c58fe7ce0294ee1f28e6450390c75bfb4..4fb48f62ba5f9c812261c16de641313b1c637118 100644 (file)
@@ -1281,7 +1281,7 @@ static void imx_eth_realize(DeviceState *dev, Error **errp)
     SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
 
     memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s,
-                          TYPE_IMX_FEC, 0x400);
+                          TYPE_IMX_FEC, FSL_IMX25_FEC_SIZE);
     sysbus_init_mmio(sbd, &s->iomem);
     sysbus_init_irq(sbd, &s->irq[0]);
     sysbus_init_irq(sbd, &s->irq[1]);
index d0e8e9d9567bbca55ada11c92d37fb72336bd272..65a73714efec223270a56fd7e02fb75af2522149 100644 (file)
@@ -192,7 +192,6 @@ typedef struct FslIMX25State {
 #define FSL_IMX25_UART5_ADDR    0x5002C000
 #define FSL_IMX25_UART5_SIZE    0x4000
 #define FSL_IMX25_FEC_ADDR      0x50038000
-#define FSL_IMX25_FEC_SIZE      0x4000
 #define FSL_IMX25_CCM_ADDR      0x53F80000
 #define FSL_IMX25_CCM_SIZE      0x4000
 #define FSL_IMX25_GPT4_ADDR     0x53F84000
index 91ef8f89a6f8caf04ca5a4ebf6d19e9864c5d187..7b3faa4019495e785cf80e9178ec2026f4f211a9 100644 (file)
@@ -245,6 +245,7 @@ typedef struct {
 
 #define ENET_TX_RING_NUM       3
 
+#define FSL_IMX25_FEC_SIZE      0x4000
 
 typedef struct IMXFECState {
     /*< private >*/