devlink: remove converted commands from small ops

As the commands are already defined in split ops, remove them
from small ops.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20230811155714.1736405-10-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
index 7caa385703de7a8f36127b471c39ffd4c97eeeb9..eb1d5066c73fe208c42ef5704a46ff79a08c1cd4 100644 (file)
--- a/net/devlink/devl_internal.h
+++ b/net/devlink/devl_internal.h
@@ -118,7 +118,7 @@ typedef int devlink_nl_dump_one_func_t(struct sk_buff *msg,
                                       struct netlink_callback *cb,
                                       int flags);
 
-extern const struct genl_small_ops devlink_nl_small_ops[54];
+extern const struct genl_small_ops devlink_nl_small_ops[40];
 
 struct devlink *
 devlink_get_from_attrs_lock(struct net *net, struct nlattr **attrs);

diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c
index 883c65545d263b5b7fae45c035901f050da6b482..3883a90d32bb26ca41fe1a14c5bd74f6dfcb4cdc 100644 (file)
--- a/net/devlink/leftover.c
+++ b/net/devlink/leftover.c
@@ -6307,15 +6307,7 @@ static int devlink_nl_cmd_trap_policer_set_doit(struct sk_buff *skb,
        return devlink_trap_policer_set(devlink, policer_item, info);
 }
 
-const struct genl_small_ops devlink_nl_small_ops[54] = {
-       {
-               .cmd = DEVLINK_CMD_PORT_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_port_get_doit,
-               .dumpit = devlink_nl_port_get_dumpit,
-               .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
-               /* can be retrieved by unprivileged users */
-       },
+const struct genl_small_ops devlink_nl_small_ops[40] = {
        {
                .cmd = DEVLINK_CMD_PORT_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6323,12 +6315,6 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .flags = GENL_ADMIN_PERM,
                .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
        },
-       {
-               .cmd = DEVLINK_CMD_RATE_GET,
-               .doit = devlink_nl_rate_get_doit,
-               .dumpit = devlink_nl_rate_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_RATE_SET,
                .doit = devlink_nl_cmd_rate_set_doit,
@@ -6369,45 +6355,18 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .flags = GENL_ADMIN_PERM,
                .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
        },
-       {
-               .cmd = DEVLINK_CMD_LINECARD_GET,
-               .doit = devlink_nl_linecard_get_doit,
-               .dumpit = devlink_nl_linecard_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
+
        {
                .cmd = DEVLINK_CMD_LINECARD_SET,
                .doit = devlink_nl_cmd_linecard_set_doit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_SB_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_sb_get_doit,
-               .dumpit = devlink_nl_sb_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
-       {
-               .cmd = DEVLINK_CMD_SB_POOL_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_sb_pool_get_doit,
-               .dumpit = devlink_nl_sb_pool_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_SB_POOL_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
                .doit = devlink_nl_cmd_sb_pool_set_doit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_SB_PORT_POOL_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_sb_port_pool_get_doit,
-               .dumpit = devlink_nl_sb_port_pool_get_dumpit,
-               .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_SB_PORT_POOL_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6415,14 +6374,6 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .flags = GENL_ADMIN_PERM,
                .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
        },
-       {
-               .cmd = DEVLINK_CMD_SB_TC_POOL_BIND_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_sb_tc_pool_bind_get_doit,
-               .dumpit = devlink_nl_sb_tc_pool_bind_get_dumpit,
-               .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_SB_TC_POOL_BIND_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6496,13 +6447,6 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .doit = devlink_nl_cmd_reload,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_PARAM_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_param_get_doit,
-               .dumpit = devlink_nl_param_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_PARAM_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6524,13 +6468,6 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .flags = GENL_ADMIN_PERM,
                .internal_flags = DEVLINK_NL_FLAG_NEED_PORT,
        },
-       {
-               .cmd = DEVLINK_CMD_REGION_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_region_get_doit,
-               .dumpit = devlink_nl_region_get_dumpit,
-               .flags = GENL_ADMIN_PERM,
-       },
        {
                .cmd = DEVLINK_CMD_REGION_NEW,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6550,14 +6487,6 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .dumpit = devlink_nl_cmd_region_read_dumpit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_HEALTH_REPORTER_GET,
-               .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
-               .doit = devlink_nl_health_reporter_get_doit,
-               .dumpit = devlink_nl_health_reporter_get_dumpit,
-               .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_HEALTH_REPORTER_SET,
                .validate = GENL_DONT_VALIDATE_STRICT | GENL_DONT_VALIDATE_DUMP,
@@ -6606,45 +6535,21 @@ const struct genl_small_ops devlink_nl_small_ops[54] = {
                .doit = devlink_nl_cmd_flash_update,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_TRAP_GET,
-               .doit = devlink_nl_trap_get_doit,
-               .dumpit = devlink_nl_trap_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_TRAP_SET,
                .doit = devlink_nl_cmd_trap_set_doit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_TRAP_GROUP_GET,
-               .doit = devlink_nl_trap_group_get_doit,
-               .dumpit = devlink_nl_trap_group_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_TRAP_GROUP_SET,
                .doit = devlink_nl_cmd_trap_group_set_doit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_TRAP_POLICER_GET,
-               .doit = devlink_nl_trap_policer_get_doit,
-               .dumpit = devlink_nl_trap_policer_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_TRAP_POLICER_SET,
                .doit = devlink_nl_cmd_trap_policer_set_doit,
                .flags = GENL_ADMIN_PERM,
        },
-       {
-               .cmd = DEVLINK_CMD_SELFTESTS_GET,
-               .doit = devlink_nl_selftests_get_doit,
-               .dumpit = devlink_nl_selftests_get_dumpit,
-               /* can be retrieved by unprivileged users */
-       },
        {
                .cmd = DEVLINK_CMD_SELFTESTS_RUN,
                .doit = devlink_nl_cmd_selftests_run,