f2fs: avoid to check PG_error flag

After below changes:
commit 14db0b3c7b83 ("fscrypt: stop using PG_error to track error status")
commit 98dc08bae678 ("fsverity: stop using PG_error to track error status")

There is no place in f2fs we will set PG_error flag in page, let's remove
other PG_error usage in f2fs, as a step towards freeing the PG_error flag
for other uses.

Cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 60fb44a200c1af62118b11aa629e2e2cdee59501..af906ed6d53d36db7edca84c06fc5abb0dafc9e4 100644 (file)
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2701,7 +2701,6 @@ got_it:
                        goto out_writepage;
 
                set_page_writeback(page);
-               ClearPageError(page);
                f2fs_put_dnode(&dn);
                if (fio->need_lock == LOCK_REQ)
                        f2fs_unlock_op(fio->sbi);
@@ -2737,7 +2736,6 @@ got_it:
                goto out_writepage;
 
        set_page_writeback(page);
-       ClearPageError(page);
 
        if (fio->compr_blocks && fio->old_blkaddr == COMPRESS_ADDR)
                f2fs_i_compr_blocks_update(inode, fio->compr_blocks - 1, false);

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 83e68ec7763de8be7d26d2352fa0e3dca00742eb..7444c392eab161159ae9b97dff2bf1ec30e93c70 100644 (file)
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1364,7 +1364,6 @@ static int move_data_block(struct inode *inode, block_t bidx,
                dec_page_count(fio.sbi, F2FS_DIRTY_META);
 
        set_page_writeback(fio.encrypted_page);
-       ClearPageError(page);
 
        fio.op = REQ_OP_WRITE;
        fio.op_flags = REQ_SYNC;

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 21a495234ffd7f22bc63f8bc05b02acd6e4ee4f7..08e302d32118d4b65de3b90a86d4f64e77b235da 100644 (file)
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -174,7 +174,6 @@ int f2fs_convert_inline_page(struct dnode_of_data *dn, struct page *page)
 
        /* write data page to try to make data consistent */
        set_page_writeback(page);
-       ClearPageError(page);
        fio.old_blkaddr = dn->data_blkaddr;
        set_inode_flag(dn->inode, FI_HOT_DATA);
        f2fs_outplace_write_data(dn, &fio);

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index dde4c045870494d3a67de53458e1b60649461084..558b318f73167bc131c5a2deb50829097ea4e09b 100644 (file)
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1650,7 +1650,6 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,
        }
 
        set_page_writeback(page);
-       ClearPageError(page);
 
        fio.old_blkaddr = ni.blk_addr;
        f2fs_do_write_node_page(nid, &fio);
@@ -2079,8 +2078,6 @@ int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi,
                spin_unlock_irqrestore(&sbi->fsync_node_lock, flags);
 
                f2fs_wait_on_page_writeback(page, NODE, true, false);
-               if (TestClearPageError(page))
-                       ret = -EIO;
 
                put_page(page);
 

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 37117cb530aeddfd09e3c298a38efe488d9950e7..a27ffc6272645568261858f059bba797604e99df 100644 (file)
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -3422,7 +3422,6 @@ void f2fs_do_write_meta_page(struct f2fs_sb_info *sbi, struct page *page,
                fio.op_flags &= ~REQ_META;
 
        set_page_writeback(page);
-       ClearPageError(page);
        f2fs_submit_page_write(&fio);
 
        stat_inc_meta_count(sbi, page->index);