vmdk: vmdk_read_cid returns garbage if p_name is NULL
authorPavel Borzenkov <pavel.borzenkov@gmail.com>
Tue, 18 Oct 2011 17:19:03 +0000 (21:19 +0400)
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Wed, 26 Oct 2011 12:36:35 +0000 (13:36 +0100)
Spotted by Clang Analyzer

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
block/vmdk.c

index 396913166a8f14ae7b5528eb6cfb2ffb3bacba9b..a75dcc2b8850957b23b207173be05b2137e667b5 100644 (file)
@@ -207,7 +207,7 @@ static void vmdk_free_last_extent(BlockDriverState *bs)
 static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent)
 {
     char desc[DESC_SIZE];
-    uint32_t cid;
+    uint32_t cid = 0xffffffff;
     const char *p_name, *cid_str;
     size_t cid_str_size;
     BDRVVmdkState *s = bs->opaque;