mmc: atmel-mci: Simplify if(chan) and if(!chan)
authorWan Jiabing <wanjiabing@vivo.com>
Wed, 27 Apr 2022 12:03:09 +0000 (20:03 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 4 May 2022 09:56:02 +0000 (11:56 +0200)
Use if(!host->dma.chan) instead of if(chan) and if(!chan) to make
code better.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20220427120310.838843-1-wanjiabing@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/atmel-mci.c

index 807177c953f3de217b2732337e02604fca75a5cd..91d52ba7a39fc30f9e78d28753299a2e194dec31 100644 (file)
@@ -1122,13 +1122,12 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
        }
 
        /* If we don't have a channel, we can't do DMA */
-       chan = host->dma.chan;
-       if (chan)
-               host->data_chan = chan;
-
-       if (!chan)
+       if (!host->dma.chan)
                return -ENODEV;
 
+       chan = host->dma.chan;
+       host->data_chan = chan;
+
        if (data->flags & MMC_DATA_READ) {
                host->dma_conf.direction = slave_dirn = DMA_DEV_TO_MEM;
                maxburst = atmci_convert_chksize(host,