ext4: correct the left/middle/right debug message for binsearch
authoryangerkun <yangerkun@huawei.com>
Fri, 3 Sep 2021 06:27:46 +0000 (14:27 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 4 Nov 2021 14:33:24 +0000 (10:33 -0400)
The debuginfo for binsearch want to show the left/middle/right extent
while the process search for the goal block. However we show this info
after we change right or left.

Link: https://lore.kernel.org/r/20210903062748.4118886-2-yangerkun@huawei.com
Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents.c

index 0e02571f2f828052111f36b066024ff7d98573a6..c59426f1e1d2a7172d2df4a324c3fdb166846207 100644 (file)
@@ -714,13 +714,14 @@ ext4_ext_binsearch_idx(struct inode *inode,
        r = EXT_LAST_INDEX(eh);
        while (l <= r) {
                m = l + (r - l) / 2;
+               ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,
+                         le32_to_cpu(l->ei_block), m, le32_to_cpu(m->ei_block),
+                         r, le32_to_cpu(r->ei_block));
+
                if (block < le32_to_cpu(m->ei_block))
                        r = m - 1;
                else
                        l = m + 1;
-               ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,
-                         le32_to_cpu(l->ei_block), m, le32_to_cpu(m->ei_block),
-                         r, le32_to_cpu(r->ei_block));
        }
 
        path->p_idx = l - 1;
@@ -782,13 +783,14 @@ ext4_ext_binsearch(struct inode *inode,
 
        while (l <= r) {
                m = l + (r - l) / 2;
+               ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,
+                         le32_to_cpu(l->ee_block), m, le32_to_cpu(m->ee_block),
+                         r, le32_to_cpu(r->ee_block));
+
                if (block < le32_to_cpu(m->ee_block))
                        r = m - 1;
                else
                        l = m + 1;
-               ext_debug(inode, "%p(%u):%p(%u):%p(%u) ", l,
-                         le32_to_cpu(l->ee_block), m, le32_to_cpu(m->ee_block),
-                         r, le32_to_cpu(r->ee_block));
        }
 
        path->p_ext = l - 1;