x86/crash: remove the unused image parameter from prepare_elf_headers()

Patch series "crash: Some cleanups and fixes", v2.

This patchset includes two cleanups and one fix.

This patch (of 3):

The image parameter is no longer in use, remove it.  Also, tidy up the
code formatting.

Link: https://lkml.kernel.org/r/20240102144905.110047-1-ytcoode@gmail.com
Link: https://lkml.kernel.org/r/20240102144905.110047-2-ytcoode@gmail.com
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Borislav Petkov (AMD) <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Hari Bathini <hbathini@linux.ibm.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Sourabh Jain <sourabhjain@linux.ibm.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
index 1715e5f06a59772a3915e1bfe8d67bee76cb1b19..14ca3efb50406d550b6589465f5f7b1522cffc85 100644 (file)
--- a/arch/x86/kernel/crash.c
+++ b/arch/x86/kernel/crash.c
@@ -198,8 +198,8 @@ static int prepare_elf64_ram_headers_callback(struct resource *res, void *arg)
 }
 
 /* Prepare elf headers. Return addr and size */
-static int prepare_elf_headers(struct kimage *image, void **addr,
-                                       unsigned long *sz, unsigned long *nr_mem_ranges)
+static int prepare_elf_headers(void **addr, unsigned long *sz,
+                              unsigned long *nr_mem_ranges)
 {
        struct crash_mem *cmem;
        int ret;
@@ -221,7 +221,7 @@ static int prepare_elf_headers(struct kimage *image, void **addr,
        *nr_mem_ranges = cmem->nr_ranges;
 
        /* By default prepare 64bit headers */
-       ret =  crash_prepare_elf64_headers(cmem, IS_ENABLED(CONFIG_X86_64), addr, sz);
+       ret = crash_prepare_elf64_headers(cmem, IS_ENABLED(CONFIG_X86_64), addr, sz);
 
 out:
        vfree(cmem);
@@ -349,7 +349,7 @@ int crash_load_segments(struct kimage *image)
                                  .buf_max = ULONG_MAX, .top_down = false };
 
        /* Prepare elf headers and add a segment */
-       ret = prepare_elf_headers(image, &kbuf.buffer, &kbuf.bufsz, &pnum);
+       ret = prepare_elf_headers(&kbuf.buffer, &kbuf.bufsz, &pnum);
        if (ret)
                return ret;
 
@@ -452,7 +452,7 @@ void arch_crash_handle_hotplug_event(struct kimage *image)
         * Create the new elfcorehdr reflecting the changes to CPU and/or
         * memory resources.
         */
-       if (prepare_elf_headers(image, &elfbuf, &elfsz, &nr_mem_ranges)) {
+       if (prepare_elf_headers(&elfbuf, &elfsz, &nr_mem_ranges)) {
                pr_err("unable to create new elfcorehdr");
                goto out;
        }