gpio: sim: delimit the fwnode name with a ":" when generating labels
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 20 Feb 2024 13:54:31 +0000 (14:54 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 26 Feb 2024 15:43:51 +0000 (16:43 +0100)
Typically, whenever a human-readable name is created for objects using
a software node, its name is delimited with ":" as dashes are often used
in other parts of the name. Make gpio-sim use the same pattern. This
results in better looking default names:

  gpio-sim.0:node0
  gpio-sim.0:node1
  gpio-sim.1:node0

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-sim.c

index db42dc5616e4f02c36e6f5624fc163f13c34d4b4..a2706fe1340a27bd607d10e0ea8ae59e5eae0769 100644 (file)
@@ -421,7 +421,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
 
        ret = fwnode_property_read_string(swnode, "gpio-sim,label", &label);
        if (ret) {
-               label = devm_kasprintf(dev, GFP_KERNEL, "%s-%pfwP",
+               label = devm_kasprintf(dev, GFP_KERNEL, "%s:%pfwP",
                                       dev_name(dev), swnode);
                if (!label)
                        return -ENOMEM;
@@ -836,7 +836,7 @@ static int gpio_sim_add_hogs(struct gpio_sim_device *dev)
                                                          GFP_KERNEL);
                        else
                                hog->chip_label = kasprintf(GFP_KERNEL,
-                                                       "gpio-sim.%u-%pfwP",
+                                                       "gpio-sim.%u:%pfwP",
                                                        dev->id,
                                                        bank->swnode);
                        if (!hog->chip_label) {