net: dsa: ksz_common: remove phylink_mac_config from ksz_dev_ops
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 26 Apr 2024 16:07:58 +0000 (17:07 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 Apr 2024 02:02:35 +0000 (19:02 -0700)
The phylink_mac_config function pointer member of struct ksz_dev_ops is
never initialised, so let's remove it to simplify the code.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/E1s0O7C-009gpk-Dh@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/microchip/ksz_common.c
drivers/net/dsa/microchip/ksz_common.h

index 2b510f150dd888421764dc1ec893bdd357eba9bf..f4469ee24239b8ff53ee56d12bd58ca110a0c17e 100644 (file)
@@ -3087,9 +3087,6 @@ static void ksz_phylink_mac_config(struct dsa_switch *ds, int port,
 
        ksz_set_xmii(dev, port, state->interface);
 
-       if (dev->dev_ops->phylink_mac_config)
-               dev->dev_ops->phylink_mac_config(dev, port, mode, state);
-
        if (dev->dev_ops->setup_rgmii_delay)
                dev->dev_ops->setup_rgmii_delay(dev, port);
 }
index 40c11b0d6b625d9a9b762efdbb71f46ab76a995a..c88ab5e89eccb7c98b79418f2698459c93473cfd 100644 (file)
@@ -349,9 +349,6 @@ struct ksz_dev_ops {
        int (*change_mtu)(struct ksz_device *dev, int port, int mtu);
        void (*freeze_mib)(struct ksz_device *dev, int port, bool freeze);
        void (*port_init_cnt)(struct ksz_device *dev, int port);
-       void (*phylink_mac_config)(struct ksz_device *dev, int port,
-                                  unsigned int mode,
-                                  const struct phylink_link_state *state);
        void (*phylink_mac_link_up)(struct ksz_device *dev, int port,
                                    unsigned int mode,
                                    phy_interface_t interface,