staging: vt6655: Type encoding info dropped from variable name "apTailTD"
authorPavan Bobba <opensource206@gmail.com>
Tue, 31 Oct 2023 05:34:34 +0000 (11:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Nov 2023 12:47:42 +0000 (12:47 +0000)
variable name "apTailTD" updated like below:

a.type encoding info dropped from name
b.camelcase name replaced by snakecase

Issue found by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/482553f089fe86dc7ebecd96c9397cfaa9c7bdf9.1698730318.git.opensource206@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/card.c
drivers/staging/vt6655/device.h
drivers/staging/vt6655/device_main.c

index d20afbc1072fd2f117ab8b010c189c249af82e87..36183f2a64c11af1470df0b376bd4b3d4443b3d6 100644 (file)
@@ -388,10 +388,10 @@ void card_safe_reset_tx(struct vnt_private *priv)
        struct vnt_tx_desc *curr_td;
 
        /* initialize TD index */
-       priv->apTailTD[0] = &priv->apTD0Rings[0];
+       priv->tail_td[0] = &priv->apTD0Rings[0];
        priv->apCurrTD[0] = &priv->apTD0Rings[0];
 
-       priv->apTailTD[1] = &priv->apTD1Rings[0];
+       priv->tail_td[1] = &priv->apTD1Rings[0];
        priv->apCurrTD[1] = &priv->apTD1Rings[0];
 
        for (uu = 0; uu < TYPE_MAXTD; uu++)
index fadbfccf42de32c684efcc03ababa11eea680691..0212240ba23f9102421a9a6d16c1807e9781277f 100644 (file)
@@ -133,7 +133,7 @@ struct vnt_private {
        volatile int                iTDUsed[TYPE_MAXTD];
 
        struct vnt_tx_desc *apCurrTD[TYPE_MAXTD];
-       struct vnt_tx_desc *apTailTD[TYPE_MAXTD];
+       struct vnt_tx_desc *tail_td[TYPE_MAXTD];
 
        struct vnt_tx_desc *apTD0Rings;
        struct vnt_tx_desc *apTD1Rings;
index a1f3dc25ad0ed66849993e8e266ec0b4abb15156..b0b262de648014759e6425ab48d2c5b510229ef2 100644 (file)
@@ -737,7 +737,7 @@ static int device_init_td0_ring(struct vnt_private *priv)
 
        if (i > 0)
                priv->apTD0Rings[i - 1].next_desc = cpu_to_le32(priv->td0_pool_dma);
-       priv->apTailTD[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
+       priv->tail_td[0] = priv->apCurrTD[0] = &priv->apTD0Rings[0];
 
        return 0;
 
@@ -777,7 +777,7 @@ static int device_init_td1_ring(struct vnt_private *priv)
 
        if (i > 0)
                priv->apTD1Rings[i - 1].next_desc = cpu_to_le32(priv->td1_pool_dma);
-       priv->apTailTD[1] = priv->apCurrTD[1] = &priv->apTD1Rings[0];
+       priv->tail_td[1] = priv->apCurrTD[1] = &priv->apTD1Rings[0];
 
        return 0;
 
@@ -969,7 +969,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
        unsigned char byTsr0;
        unsigned char byTsr1;
 
-       for (desc = priv->apTailTD[idx]; priv->iTDUsed[idx] > 0; desc = desc->next) {
+       for (desc = priv->tail_td[idx]; priv->iTDUsed[idx] > 0; desc = desc->next) {
                if (desc->td0.owner == OWNED_BY_NIC)
                        break;
                if (works++ > 15)
@@ -1007,7 +1007,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
                }
        }
 
-       priv->apTailTD[idx] = desc;
+       priv->tail_td[idx] = desc;
 
        return works;
 }