staging: r8188eu: remove unused ijk_matrix_regs_set implementation
authorDeepak R Varma <drv@mailo.com>
Thu, 3 Nov 2022 17:28:06 +0000 (22:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Nov 2022 15:26:17 +0000 (16:26 +0100)
Instance IQKMatrixRegSetting of struct ijk_matrix_regs_set is
initialised and its member variables are assigned values, but it is
not used anywhere. Remove the structure and its unused implementation.

Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Deepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/Y2P6Jj+IcPss0wFd@qemulion
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
drivers/staging/r8188eu/include/odm.h

index 622f95d3f2edf1f11f3f9f06b0b99f3308df6529..26e710ef5134d2009a640b6b3c31754b4038f554 100644 (file)
@@ -882,14 +882,6 @@ void PHY_IQCalibrate_8188E(struct adapter *adapt, bool recovery)
        if (RegE94 != 0)
                patha_fill_iqk(adapt, pathaok, result, final_candidate, (RegEA4 == 0));
 
-/* To Fix BSOD when final_candidate is 0xff */
-/* by sherry 20120321 */
-       if (final_candidate < 4) {
-               for (i = 0; i < IQK_Matrix_REG_NUM; i++)
-                       dm_odm->RFCalibrateInfo.IQKMatrixRegSetting.Value[0][i] = result[final_candidate][i];
-               dm_odm->RFCalibrateInfo.IQKMatrixRegSetting.bIQKDone = true;
-       }
-
        _PHY_SaveADDARegisters(adapt, IQK_BB_REG_92C, dm_odm->RFCalibrateInfo.IQK_BB_backup_recover, 9);
 }
 
index 89b01dd614ba9fe1a64e5e610473a659bc218208..8cea166b7b735ca09335b1f3b6177f1ddc51e94a 100644 (file)
@@ -80,7 +80,6 @@ struct odm_rate_adapt {
 #define HP_THERMAL_NUM         8
 
 #define AVG_THERMAL_NUM                8
-#define IQK_Matrix_REG_NUM     8
 
 struct odm_phy_dbg_info {
        /* ODM Write,debug info */
@@ -164,11 +163,6 @@ struct odm_ra_info {
        u8 PTSmoothFactor;
 };
 
-struct ijk_matrix_regs_set {
-       bool    bIQKDone;
-       s32     Value[1][IQK_Matrix_REG_NUM];
-};
-
 struct odm_rf_cal {
        /* for tx power tracking */
        u32     RegA24; /*  for TempCCK */
@@ -206,7 +200,6 @@ struct odm_rf_cal {
 
        u8      ThermalValue_HP[HP_THERMAL_NUM];
        u8      ThermalValue_HP_index;
-       struct ijk_matrix_regs_set IQKMatrixRegSetting;
 
        u8      Delta_IQK;
        u8      Delta_LCK;