staging: vchiq_core: fix quoted strings split across lines

Quoted strings should not be split across lines. As put it in [1]:
"never break user-visible strings such as printk messages because that
breaks the ability to grep for them."

While at it, fix the alignment of the arguments in the sentence.

Note: this introduce a checkpatch CHECK: line length of 123 exceeds 100
columns, as the line now is:

 vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)",

But now the string is grep-able and the whole function call more
clear.

Reported by checkpatch.pl

[1] Documentation/process/coding-style.rst

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20211024213839.370830-1-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 3af55e78f356a215abb4bd2357709b947f0523fe..ab97a35e63f964be5a34e1e843a61416b2b5dda5 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -1499,13 +1499,9 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header)
        if ((service->version < version_min) || (version < service->version_min)) {
                /* Version mismatch */
                vchiq_loud_error_header();
-               vchiq_loud_error("%d: service %d (%c%c%c%c) "
-                       "version mismatch - local (%d, min %d)"
-                       " vs. remote (%d, min %d)",
-                       state->id, service->localport,
-                       VCHIQ_FOURCC_AS_4CHARS(fourcc),
-                       service->version, service->version_min,
-                       version, version_min);
+               vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)",
+                                state->id, service->localport, VCHIQ_FOURCC_AS_4CHARS(fourcc),
+                                service->version, service->version_min, version, version_min);
                vchiq_loud_error_footer();
                vchiq_service_put(service);
                service = NULL;