scsi: be2iscsi: set errno on error path

Variable ret is reset in the loop, and its value will be 0 during the
second and after repeat of the loop. If pci_alloc_consistent() returns a
NULL pointer then, it will leaves with return value 0. 0 means no error,
which is contrary to the fact. This patches fixes the bug, explicitly
assigning "-ENOMEM" to return variable ret on the path that the call to
pci_alloc_consistent() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188951

Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Jitendra Bhivare <Jitendra.bhivare@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index b6c5791060e5f7a4aaa22344b43efbad9a6330c6..b5112d6d7e7343a8f7bce4c0fb4089095ca53460 100644 (file)
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3049,8 +3049,10 @@ static int beiscsi_create_eqs(struct beiscsi_hba *phba,
                eq_vaddress = pci_alloc_consistent(phba->pcidev,
                                                   num_eq_pages * PAGE_SIZE,
                                                   &paddr);
-               if (!eq_vaddress)
+               if (!eq_vaddress) {
+                       ret = -ENOMEM;
                        goto create_eq_error;
+               }
 
                mem->va = eq_vaddress;
                ret = be_fill_queue(eq, phba->params.num_eq_entries,