scsi: mpt3sas: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 28 May 2021 20:08:28 +0000 (15:08 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 2 Jun 2021 04:56:15 +0000 (00:56 -0400)
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
of warnings by explicitly adding break statements instead of just letting
the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/r/20210528200828.GA39349@embeddedor
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c
drivers/scsi/mpt3sas/mpt3sas_scsih.c

index bc4ed3ed4b9ade225073ba60b254344e6e0ec149..4df8448cfbf24fccec01ac3744376347c90cc653 100644 (file)
@@ -4437,6 +4437,7 @@ _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
                                 ioc->pdev->subsystem_device);
                        break;
                }
+               break;
        default:
                break;
        }
index d70ae57d897ff4b15fde8d2a7f7f008937736202..8e7f9e744f5d7b397363e8f40f16e9768db2bbf6 100644 (file)
@@ -12082,6 +12082,7 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                                ioc->multipath_on_hba = 1;
                        else
                                ioc->multipath_on_hba = 0;
+                       break;
                default:
                        break;
                }