cxl/pci: Remove pci request/release regions
authorBen Widawsky <ben.widawsky@intel.com>
Sat, 9 Oct 2021 16:44:18 +0000 (09:44 -0700)
committerDan Williams <dan.j.williams@intel.com>
Fri, 29 Oct 2021 18:53:51 +0000 (11:53 -0700)
Quoting Dan, "... the request + release regions should probably just be
dropped. It's not like any of the register enumeration would collide
with someone else who already has the registers mapped. The collision
only comes when the registers are mapped for their final usage, and that
will have more precision in the request."

Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
Link: https://lore.kernel.org/r/163379785872.692348.8981679111988251260.stgit@dwillia2-desk3.amr.corp.intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/pci.c

index 9c178002d49e73dfb17fe11f0292899164943bd4..21dd10a77eb3a8e6803a4dbca7da7e194dfd101c 100644 (file)
@@ -453,9 +453,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
                return -ENXIO;
        }
 
-       if (pci_request_mem_regions(pdev, pci_name(pdev)))
-               return -ENODEV;
-
        /* Get the size of the Register Locator DVSEC */
        pci_read_config_dword(pdev, regloc + PCI_DVSEC_HEADER1, &regloc_size);
        regloc_size = FIELD_GET(PCI_DVSEC_HEADER1_LENGTH_MASK, regloc_size);
@@ -499,8 +496,6 @@ static int cxl_pci_setup_regs(struct cxl_mem *cxlm)
                n_maps++;
        }
 
-       pci_release_mem_regions(pdev);
-
        for (i = 0; i < n_maps; i++) {
                ret = cxl_map_regs(cxlm, &maps[i]);
                if (ret)