x86/smp: Remove unnecessary assignment to local var freq_scale
authorTim Gardner <tim.gardner@canonical.com>
Fri, 10 Sep 2021 18:44:05 +0000 (12:44 -0600)
committerBorislav Petkov <bp@suse.de>
Fri, 17 Sep 2021 19:20:34 +0000 (21:20 +0200)
Coverity warns of an unused value in arch_scale_freq_tick():

  CID 100778 (#1 of 1): Unused value (UNUSED_VALUE)
  assigned_value: Assigning value 1024ULL to freq_scale here, but that stored
  value is overwritten before it can be used.

It was introduced by commit:

  e2b0d619b400a ("x86, sched: check for counters overflow in frequency invariant accounting")

Remove the variable initializer.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Giovanni Gherdovich <ggherdovich@suse.cz>
Link: https://lkml.kernel.org/r/20210910184405.24422-1-tim.gardner@canonical.com
arch/x86/kernel/smpboot.c

index 85f6e242b6b45195f74766c5a81b63a3a7e24f8c..c453b825a57f1c35175e79f0712d5c80d96b140f 100644 (file)
@@ -2166,7 +2166,7 @@ DEFINE_PER_CPU(unsigned long, arch_freq_scale) = SCHED_CAPACITY_SCALE;
 
 void arch_scale_freq_tick(void)
 {
-       u64 freq_scale = SCHED_CAPACITY_SCALE;
+       u64 freq_scale;
        u64 aperf, mperf;
        u64 acnt, mcnt;