media: i2c: ov2659: fix s_stream return value

In ov2659_s_stream() return value for invoked function should be checked
and propagated.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index f77320e8a60d62c96f1d5221377fc60549e181ad..da181a13cf44bd246f5911e932c8c4b33e712d48 100644 (file)
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1187,11 +1187,15 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on)
                goto unlock;
        }
 
-       ov2659_set_pixel_clock(ov2659);
-       ov2659_set_frame_size(ov2659);
-       ov2659_set_format(ov2659);
-       ov2659_set_streaming(ov2659, 1);
-       ov2659->streaming = on;
+       ret = ov2659_set_pixel_clock(ov2659);
+       if (!ret)
+               ret = ov2659_set_frame_size(ov2659);
+       if (!ret)
+               ret = ov2659_set_format(ov2659);
+       if (!ret) {
+               ov2659_set_streaming(ov2659, 1);
+               ov2659->streaming = on;
+       }
 
 unlock:
        mutex_unlock(&ov2659->lock);