drm/amd/display: disable RCO for DCN314
authorDaniel Miess <daniel.miess@amd.com>
Wed, 7 Jun 2023 15:11:44 +0000 (11:11 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 23 Jun 2023 19:37:48 +0000 (15:37 -0400)
[Why]
RCO is causing error messages on some DCN314 systems

[How]
Force disable RCO for DCN314

Fixes: 17fbdbda9cc8 ("drm/amd/display: Enable dcn314 DPP RCO")
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Daniel Miess <daniel.miess@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c
drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c

index cf23d7bc560a6c92aef84c00f1b081a59b21a6bd..0746ed31d1d14ae9d511b6db9efe04a41c251d68 100644 (file)
@@ -332,7 +332,7 @@ static void dccg314_dpp_root_clock_control(
 {
        struct dcn_dccg *dccg_dcn = TO_DCN_DCCG(dccg);
 
-       if (dccg->dpp_clock_gated[dpp_inst] == clock_on)
+       if (dccg->dpp_clock_gated[dpp_inst] != clock_on)
                return;
 
        if (clock_on) {
index ef49b4d7742f7de34f4d64810089addcbb7ba4ac..6a9024aa32853178d94e661ccecbde93e3aeaf37 100644 (file)
@@ -1908,6 +1908,9 @@ static bool dcn314_resource_construct(
        dc->debug.disable_dpp_power_gate = true;
        dc->debug.disable_hubp_power_gate = true;
 
+       /* Disable root clock optimization */
+       dc->debug.root_clock_optimization.u32All = 0;
+
        // Init the vm_helper
        if (dc->vm_helper)
                vm_helper_init(dc->vm_helper, 16);