Bluetooth: hci_qca: Fix uninitialized access to hdev
authorAbhishek Pandit-Subedi <abhishekpandit@chromium.org>
Wed, 20 May 2020 16:32:28 +0000 (09:32 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 20 May 2020 17:12:43 +0000 (19:12 +0200)
hdev is always allocated and not only when power control is required.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c

index 26efe822f6e58a228c50d86e0704462fda6b83d9..e4a68238fcb9330aa557fd75ab7f9b4b18c32f3b 100644 (file)
@@ -1947,8 +1947,9 @@ static int qca_serdev_probe(struct serdev_device *serdev)
                }
        }
 
+       hdev = qcadev->serdev_hu.hdev;
+
        if (power_ctrl_enabled) {
-               hdev = qcadev->serdev_hu.hdev;
                set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
                hdev->shutdown = qca_power_off;
        }