PCI: tegra194: Use Mbps_to_icc() macro for setting icc speed
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 4 Oct 2023 16:44:30 +0000 (22:14 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Sat, 14 Oct 2023 19:19:37 +0000 (19:19 +0000)
PCIe speed returned by the PCIE_SPEED2MBS_ENC() macro is in Mbps. So
instead of converting it to MBps explicitly and using the MBps_to_icc()
macro, let's use the Mbps_to_icc() macro to pass the value directly.

Link: https://lore.kernel.org/linux-pci/20231004164430.39662-3-manivannan.sadhasivam@linaro.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Vidya Sagar <vidyas@nvidia.com>
drivers/pci/controller/dwc/pcie-tegra194.c

index 4bba31502ce1d65ca5320c78c8d79cebc67be82c..5feac690e1270363baed2cd477a7280de95575b5 100644 (file)
@@ -321,9 +321,9 @@ static void tegra_pcie_icc_set(struct tegra_pcie_dw *pcie)
        speed = FIELD_GET(PCI_EXP_LNKSTA_CLS, val);
        width = FIELD_GET(PCI_EXP_LNKSTA_NLW, val);
 
-       val = width * (PCIE_SPEED2MBS_ENC(pcie_link_speed[speed]) / BITS_PER_BYTE);
+       val = width * PCIE_SPEED2MBS_ENC(pcie_link_speed[speed]);
 
-       if (icc_set_bw(pcie->icc_path, MBps_to_icc(val), 0))
+       if (icc_set_bw(pcie->icc_path, Mbps_to_icc(val), 0))
                dev_err(pcie->dev, "can't set bw[%u]\n", val);
 
        if (speed >= ARRAY_SIZE(pcie_gen_freq))