iio: adc: exynos_adc: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:05 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:18 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429113313.68359-3-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/exynos_adc.c

index 614de96448003e652aafabfdbeb089dd7c306a9d..78fada4b7b1c86c7612cbeb7e747e89d07748ada 100644 (file)
@@ -538,7 +538,7 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
                                long mask)
 {
        struct exynos_adc *info = iio_priv(indio_dev);
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        if (mask == IIO_CHAN_INFO_SCALE) {
@@ -562,9 +562,9 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
        if (info->data->start_conv)
                info->data->start_conv(info, chan->address);
 
-       timeout = wait_for_completion_timeout(&info->completion,
-                                             EXYNOS_ADC_TIMEOUT);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&info->completion,
+                                               EXYNOS_ADC_TIMEOUT);
+       if (time_left == 0) {
                dev_warn(&indio_dev->dev, "Conversion timed out! Resetting\n");
                if (info->data->init_hw)
                        info->data->init_hw(info);
@@ -583,7 +583,7 @@ static int exynos_read_raw(struct iio_dev *indio_dev,
 static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
 {
        struct exynos_adc *info = iio_priv(indio_dev);
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        mutex_lock(&info->lock);
@@ -597,9 +597,9 @@ static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
        /* Select the ts channel to be used and Trigger conversion */
        info->data->start_conv(info, ADC_S3C2410_MUX_TS);
 
-       timeout = wait_for_completion_timeout(&info->completion,
-                                             EXYNOS_ADC_TIMEOUT);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&info->completion,
+                                               EXYNOS_ADC_TIMEOUT);
+       if (time_left == 0) {
                dev_warn(&indio_dev->dev, "Conversion timed out! Resetting\n");
                if (info->data->init_hw)
                        info->data->init_hw(info);